fix: make metadata fields optional to handle missing API responses - #130
Open
ishii-masaki-646 wants to merge 1 commit into
Open
fix: make metadata fields optional to handle missing API responses#130ishii-masaki-646 wants to merge 1 commit into
ishii-masaki-646 wants to merge 1 commit into
Conversation
The Gyazo API may return images without metadata or with null metadata fields. This caused runtime errors when accessing metadata properties. Updated the GyazoImage type and added optional chaining where metadata is accessed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ishii-masaki-646
added a commit
to ishii-masaki-646/gyazo-mcp-server-forked-from-official
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GyazoImage型のmetadataとその各フィールド(app,title,url,desc)を optional + null 許容に変更metadataにアクセスする箇所でオプショナルチェーン (?.) を追加し、metadataが存在しない画像でのランタイムエラーを防止Test plan
metadataが存在しない画像でリソース一覧取得がエラーにならないことを確認metadataが存在しない画像でメタデータ Markdown 生成がエラーにならないことを確認metadataが存在する画像で従来通り正しく動作することを確認🤖 Generated with Claude Code