Fix errors when using upcoming scala 3.5.0 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a bug in the compiler could remove some parts of the code before an inline match. In this project, this prevented the exception `inline val with null is not supported` from appearing, since this check is done later in the compilation pipeline. Since that is fixed in 3.5.0, the exception can appear now. Unfortunately, currently I do not have a better solution for this. `case res => res` (for now) only works in scala 3.4.0 and later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was picked up on scala 3's open-community-build: scala/scala3#20292
Previously, a bug in the compiler could remove some parts of the code before an inline match. In this project, this prevented the exception
inline val with null is not supportedfrom appearing, since this check is done later in the compilation pipeline. Since that is fixed in 3.5.0, the exception can appear now.Unfortunately, currently I do not have any better solution for this.
case res => res(for now) only works in scala 3.4.0 and later, but it should be possible in the future.