Skip to content

Speed up Websock receive queue reads via DataView #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PekingSpades wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −12
Open

Speed up Websock receive queue reads via DataView #2024

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f73e2e
Use DataView for receive queue shifts
PekingSpades Nov 18, 2025
de7723c
Inline DataView reads in rQshift methods
PekingSpades Dec 13, 2025
588d7d8
Fix tests to rebuild Websock DataView when swapping buffers
PekingSpades Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion core/websock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export default class Websock {
this._rQbufferSize = 1024 * 1024 * 4; // Receive queue buffer size (4 MiB)
// called in init: this._rQ = new Uint8Array(this._rQbufferSize);
this._rQ = null; // Receive queue
this._rQdv = null; // DataView for the receive queue buffer

this._sQbufferSize = 1024 * 10; // 10 KiB
// called in init: this._sQ = new Uint8Array(this._sQbufferSize);
Expand Down Expand Up @@ -115,8 +116,27 @@ export default class Websock {
return this._rQshift(4);
}

// TODO(directxman12): test performance with these vs a DataView
// Use DataView for faster integer reads (with a fallback for uncommon sizes)
_rQshift(bytes) {
if (!this._rQdv && this._rQ) {
this._rQdv = new DataView(this._rQ.buffer);
}

if (this._rQdv && (bytes === 1 || bytes === 2 || bytes === 4)) {
const offset = this._rQi;
this._rQi += bytes;

let res;
if (bytes === 1) {
res = this._rQdv.getUint8(offset);
} else if (bytes === 2) {
res = this._rQdv.getUint16(offset, false);
} else {
res = this._rQdv.getUint32(offset, false);
}
return res >>> 0;
}

let res = 0;
for (let byte = bytes - 1; byte >= 0; byte--) {
res += this._rQ[this._rQi++] << (byte * 8);
Expand Down Expand Up @@ -242,6 +262,7 @@ export default class Websock {

_allocateBuffers() {
this._rQ = new Uint8Array(this._rQbufferSize);
this._rQdv = new DataView(this._rQ.buffer);
this._sQ = new Uint8Array(this._sQbufferSize);
}

Expand Down Expand Up @@ -337,6 +358,7 @@ export default class Websock {
const oldRQbuffer = this._rQ.buffer;
this._rQ = new Uint8Array(this._rQbufferSize);
this._rQ.set(new Uint8Array(oldRQbuffer, this._rQi, this._rQlen - this._rQi));
this._rQdv = new DataView(this._rQ.buffer);
} else {
this._rQ.copyWithin(0, this._rQi, this._rQlen);
}
Expand Down