Repository navigation
[BUG] "url.URL is not a constructor" error on Node 6 < v6.13.0 #61
Description
What / Why
The unit tests (and actual usage in the wild) fail with the error:
"url.URL is not a constructor"
When
I run the unit tests or use the package on Node v6 (which seems to be supported?) with a version less than v6.13.0, where the URL constructor was first introduced to Node v6.
Where
All places
How
Current Behavior
- Run unit tests on Node v6 < v6.13.0 (e.g. v6.12.3) and notice the error
Steps to Reproduce
- Run unit tests on Node v6 < v6.13.0 (e.g. v6.12.3) and notice the error
Expected Behavior
- Running unit tests on all versions of Node v6 passes without error
Who
References
Introduced in PR #58
https://github.com/npm/hosted-git-info/pull/58/files#diff-168726dbe96b3ce427e7fedce31bb0bcR112
Metadata
Metadata
Assignees
Labels
No labels
Activity
fix: Do not attempt to use url.URL when unavailable
fix: do not use url.URL to support early node 6 and scp-style URLs
fix: Do not attempt to use url.URL when unavailable
fix: #61 & #65 addressing issues w/ url.URL implmentation which regre…
fix: #61 & #65 addressing issues w/ url.URL implmentation which regre…
fix: #61 & #65 addressing issues w/ url.URL implmentation which regre…
darcyclarke commentedon Feb 29, 2020
This should be fixed by #66 which was landed in
hosted-git-info@2.8.8. We'll try to roll out a cli update as soon as possible which will include this dep update (likely asnpm@6.14.2)