Repository navigation
fix: parse GitLab subgroup paths on unknown hosts - #342
Closed
dyk1454683243-sudo wants to merge 1 commit into
Closed
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Treat GROUP/SUBGROUP/REPO remotes on unrecognized git hosts as GitLab-like so fromUrl/fromManifest no longer fall back to unknownHostInfo. Custom hosts registered with addHost also get nested-path extraction by default. Fixes npm#54 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
Author
|
Withdrawing this PR while I clean up a high-volume open-PR backlog. Sorry for the noise — happy to come back later with a focused change if useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54.
GitLab subgroup remotes (
GROUP/SUBGROUP/REPO) ongitlab.comalready parsed, but the issue's self-hosted SCP form did not:fromUrlreturnedundefinedandfromManifestfell through tounknownHostedUrl, which could not parse SCP-style URLs and returnednull.Changes
GROUP/SUBGROUP/.../REPO) as GitLab-like, keeping the original hostname so generated SSH/HTTPS/browse/tarball URLs stay on the self-hosted domain..gitsuffix to avoid matching arbitrary website paths.user/repois still out of scope; see Support non-public hosts such as GitHub Enterprise #39).unknownHostedUrlnow usesparseUrl, so two-segment SCP repository fields still produce a usable HTTPS URL.addHost()defaults to nested-path extraction so similar custom hosts parse subgroups without a hand-writtenextract.Tests
Regression coverage in
test/gitlab-subgroups.jsfor:git@gitlab.com:GROUP/SUBGROUP/REPO.gitand HTTPS/git+https/git+ssh equivalentsfromManifesta/b/c/d.git)addHostcustom domainsundefinednpm testpasses (35 tests, lint clean).