Skip to content

Conversation

@ulgens
Copy link
Collaborator

@ulgens ulgens commented Feb 17, 2025

Supersedes #594

Summary by Sourcery

Remove the duplicated django dependency in pyproject.toml and update the release notes.

Bug Fixes:

  • Remove duplicate django dependency, resolving conflicts and reintroducing Django 4.2 to 5.3 support

Documentation:

  • Add release notes for the patch release

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 17, 2025

Reviewer's Guide by Sourcery

This pull request removes a duplicated Django dependency from pyproject.toml. It also adds a release type to RELEASE.md.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed duplicate Django dependency.
  • Removed the django>=5.1.3 dependency.
pyproject.toml
Added release type to RELEASE.md
  • Added release type: patch
  • Added a note about removing the duplicate Django dependency and reintroducing Django>=4.2,<5.3 support
RELEASE.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@nrbnlulu
Copy link
Owner

nrbnlulu commented Feb 17, 2025

Release Notes

Just wanted to say

success

Release type: patch

Remove duplicate Django dependency and reintroduce Django>=4.2,<5.3 support

@ulgens ulgens force-pushed the fix-duplicate-django-dep branch from 6fc467f to f1322a9 Compare February 17, 2025 11:32
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.40%. Comparing base (9c760b6) to head (e7cc3c2).
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   92.82%   93.40%   +0.57%     
==========================================
  Files          33       33              
  Lines        1478     1500      +22     
==========================================
+ Hits         1372     1401      +29     
+ Misses        106       99       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrbnlulu nrbnlulu merged commit 5c76743 into nrbnlulu:main Feb 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants