Skip to content

Conversation

@Phillip9587
Copy link
Contributor

Current Behavior

  • cra-to-nx depends on @nrwl/devkit and @nrwl/workspace but both packages are not needed and add extra install time
  • cra-to-nx npm package contains typescript declarations and sourceMaps but is just a CLI tool and should not be imported
  • cra-to-nx contains custom package manager helper functions that can be replaced by already implemented functionality from nx/src/utils/package-manager which also reduces the install size

Expected Behavior

@nx-cloud-staging
Copy link

nx-cloud-staging bot commented Nov 7, 2022

@vercel
Copy link

vercel bot commented Nov 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 7, 2022 at 7:54PM (UTC)

@FrozenPandaz FrozenPandaz merged commit a218149 into nrwl:master Nov 8, 2022
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

FrozenPandaz pushed a commit that referenced this pull request Nov 8, 2022
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants