Skip to content

fix(vite): config migration account for other syntaxes#20693

Merged
mandarini merged 1 commit intonrwl:masterfrom
mandarini:fix/vite-config-migration
Dec 11, 2023
Merged

fix(vite): config migration account for other syntaxes#20693
mandarini merged 1 commit intonrwl:masterfrom
mandarini:fix/vite-config-migration

Conversation

@mandarini
Copy link
Copy Markdown
Contributor

@mandarini mandarini commented Dec 11, 2023

Account for other syntaxes of vite.config.ts, and update guide on how Vite should be set up correctly for Nx.

@mandarini mandarini requested a review from a team as a code owner December 11, 2023 14:05
@mandarini mandarini requested a review from jaysoo December 11, 2023 14:05
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 11, 2023 3:19pm

@mandarini mandarini enabled auto-merge (squash) December 11, 2023 16:29
@mandarini mandarini merged commit 679db5d into nrwl:master Dec 11, 2023

## TypeScript paths

You need to use the `nxViteTsPaths()` plugin to make sure that your TypeScript paths are resolved correctly in your monorepo. This
Copy link
Copy Markdown

@C0ZEN C0ZEN Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This?

ping @mandarini

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meeroslav pushed a commit to meeroslav/nx that referenced this pull request Dec 14, 2023
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants