Skip to content

feat(angular): add migration to keep previous style guide behavior #31248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

leosvelperez
Copy link
Member

Adds a migration that will set relevant generator defaults to ensure existing workspaces keep using the previous style guide matching their existing code base.

It adds generator defaults for both @nx/angular and @schematics/angular collections.

@leosvelperez leosvelperez requested a review from Coly010 May 16, 2025 13:26
@leosvelperez leosvelperez self-assigned this May 16, 2025
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 16, 2025 1:35pm

@leosvelperez leosvelperez removed request for a team, jaysoo, AgentEnder and FrozenPandaz May 16, 2025 13:26
Copy link
Contributor

nx-cloud bot commented May 16, 2025

View your CI Pipeline Execution ↗ for commit 6490210.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 27m 12s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 14s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-16 13:59:02 UTC

@leosvelperez leosvelperez merged commit 4dac221 into angular/v20 May 16, 2025
6 checks passed
@leosvelperez leosvelperez deleted the angular/v20-type-and-separator-migration branch May 16, 2025 13:59
leosvelperez added a commit that referenced this pull request May 19, 2025
…31248)

Adds a migration that will set relevant generator defaults to ensure
existing workspaces keep using the previous style guide matching their
existing code base.

It adds generator defaults for both `@nx/angular` and
`@schematics/angular` collections.
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant