[All] Several fixes on main branch to pass CI#1554
Open
loumalouomega wants to merge 13 commits into
Open
Conversation
- Replace | with Union in type hints for compatibility with Python < 3.10 - Add missing topological_dimension import in meshio/__init__.py - Update tox.ini and CI to explicitly use py38 and py312 environments - Ensure tox uses the correct environment version in GitHub Actions
- Use math.prod in VTK writers (as suggested in code) - Fix argparse subparser compatibility - Refine __about__.py version discovery - General cleanup of type hints and imports
Author
|
Fantastic, now CI passes, i will try to minimize changes and pass the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several critical issues identified in the CI and provides better compatibility with modern environments (NumPy 2.0+) and older Python versions (3.8).
Summary of Changes
1. Fix Windows CI Failure (Python 3.8)
pipattempted to buildnetCDF4from source, which required HDF5 headers that were missing from the runner.tox.inito explicitly list dependencies and use environment markers (netCDF4; sys_platform != "win32" or python_version != "3.8") to skipnetCDF4only in this specific failing environment.2. NumPy 2.0+ Compatibility
repr()of scalars to include the type (e.g.,np.float64(1.23)instead of1.23). This broke several ASCII file writers that used{!r},%r, orrepr()for formatting, as the resulting files could not be parsed by standard readers.str()({!s},%s) instead ofrepr().np.fromfile(..., sep=" ")with a more reliablereadline().split()approach to handle potential whitespace/newline issues.3. Python 3.8 Compatibility & Modernization
|union type hints withtyping.Unionin several files to maintain compatibility with Python 3.8.src/meshio/__about__.pyto useimportlib.metadata(with a fallback toimportlib_metadata) more robustly.argparsesubparser requirement syntax for better compatibility across Python versions.4. Linter and CI Updates
venvand.toxto the exclusion list in.flake8to avoid false positives from third-party packages in local development environments.toxcommand in CI to explicitly select the appropriate environment (py38orpy312).Verification Results
isort,black, andflake8pass cleanly.np.float64string representation issues in NumPy 2.4.4.