Settings schema unification and file watching#209
Merged
Conversation
Three changes:
1. **Schema unification**: AppSettings now serializes to the same nested
JSON format as SyncedSettings ({ uv: { default_packages: [...] } }).
Both the daemon and notebook write the same schema to settings.json.
Backward-compat: load_settings() migrates old flat keys on read.
2. **File watching**: The daemon watches settings.json using the notify
crate with a 500ms debouncer. External edits (manual or CLI) are
detected, applied to the Automerge doc, and broadcast to all connected
windows. Self-writes are automatically skipped via field comparison.
3. **JSON Schema**: Added schemars with #[derive(JsonSchema)] on all
settings types (SyncedSettings, AppSettings, UvDefaults, CondaDefaults,
Runtime, PythonEnvType).
Also fixes #188: get_synced_settings now falls back to settings.json
when the daemon is unavailable instead of returning an error.
Co-Authored-By: QuillAid <261289082+quillaid@users.noreply.github.com>
Implements an explicit dev command to rebuild and install the daemon into the running launchd/systemd service. This solves the friction of testing daemon changes locally without manually stopping/replacing/restarting. The command: 1. Builds runtimed in release mode 2. Stops the running service (gracefully) 3. Copies the new binary over the installed one 4. Restarts the service 5. Verifies the version from daemon.json Also updates contributing/runtimed.md with the new command in the quick reference and development workflow documentation. Co-Authored-By: QuillAid <261289082+quillaid@users.noreply.github.com>
rgbkrk
commented
Feb 22, 2026
| s.conda.default_packages = packages; | ||
| settings::save_settings(&s).map_err(|e| e.to_string()) | ||
| } | ||
| // Theme has no local fallback in settings.json (handled by localStorage) |
Member
Author
There was a problem hiding this comment.
Actually theme should have a local fallback in settings.json. We can do local storage first but there is a theme key.
crates/notebook/src/settings.rs
Outdated
| settings | ||
| } | ||
|
|
||
| /// Extract packages from an old flat key (comma-separated string or array). |
Member
Author
There was a problem hiding this comment.
Considering we haven't released this yet with the flat key, it's going to be ok to rip this out before mondays pre release.
| } | ||
| } | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
The only funny thing I've noticed is that if I change the file in zed then it also reformats the file. Then the daemon gets the update and writes the file with the new setting back but formatted in its own json way. Just to cause less churn I feel like we should adopt json formatting here.
Separately I think we should use the json with comments format so we can leave comments in the document for the user.
| } | ||
| } | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
The only funny thing I've noticed is that if I change the file in zed then it also reformats the file. Then the daemon gets the update and writes the file with the new setting back but formatted in its own json way. Just to cause less churn I feel like we should adopt json formatting here.
Separately I think we should use the json with comments format so we can leave comments in the document for the user.
Co-Authored-By: QuillAid <261289082+quillaid@users.noreply.github.com>
- Remove backward-compat flat key migration code from settings.rs and settings_doc.rs since the flat format was never shipped publicly - Stop writing JSON mirror in the file watcher handler to avoid reformatting the user's settings.json with serde's formatting - Remove backward compatibility docs section from settings.md - Remove related tests for flat format handling Co-Authored-By: QuillAid <261289082+quillaid@users.noreply.github.com>
Both save_json_mirror and save_settings now emit a trailing newline to match standard editor formatting, reducing churn when the user edits settings.json in their editor. The watch handler now writes the JSON mirror back (matching the sync server behavior). Co-Authored-By: QuillAid <261289082+quillaid@users.noreply.github.com>
serde_json expands arrays to one element per line, while editors like Zed keep short arrays inline. Writing the mirror back would reformat the user's file every time they save it. The user's file already has the correct values so only the Automerge binary needs persisting. Co-Authored-By: QuillAid <261289082+quillaid@users.noreply.github.com>
rgbkrk
added a commit
that referenced
this pull request
Mar 11, 2026
build-dependencies.md: - Remove stale PR #209 reference - Fix Python wheel description (pyo3, not bin bindings) - Add notebook-doc to both dependency graphs - Fix sidecar→runt-cli edge (doesn't exist) - Add runt-workspace and kernel deps to crate graph development.md: - Fix AGENTS.md → CLAUDE.md reference - Add explicit env var instructions for agents in raw terminals - Add 'Before You Commit' section with formatting requirements - Add 'Zed Editor Integration' section documenting .zed/tasks.json README.md: - Add notebook-doc to project structure tree - Add Contributing section with links to key guides
rgbkrk
added a commit
that referenced
this pull request
Mar 11, 2026
build-dependencies.md: - Remove stale PR #209 reference - Fix Python wheel description (pyo3, not bin bindings) - Add notebook-doc to both dependency graphs - Fix sidecar→runt-cli edge (doesn't exist) - Add runt-workspace and kernel deps to crate graph development.md: - Fix AGENTS.md → CLAUDE.md reference - Add explicit env var instructions for agents in raw terminals - Add 'Before You Commit' section with formatting requirements - Add 'Zed Editor Integration' section documenting .zed/tasks.json README.md: - Add notebook-doc to project structure tree - Add Contributing section with links to key guides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppSettingsto serialize in the same nested format asSyncedSettings, fixing a schema mismatch where the daemon and notebook wrote different JSON formats to the same filesettings.jsonvia notify crate with automatic change propagation to all connected notebook windowscargo xtask install-daemonfor convenient daemon upgrades during developmentget_synced_settingsfallback to use local settings file when daemon is unavailable (issue Unified settings read path: frontend should read settings.json when daemon is unavailable #188)Verification
To test the file watching workflow:
~/Library/Application Support/runt-notebook/settings.jsonmanually while the daemon is runningsettings.jsoncargo xtask install-daemonto verify daemon reinstallation and version detectionCloses #190
PR submitted by @rgbkrk's agent, Quill