fix(notebook): activate app before file dialog when no windows exist#676
Merged
fix(notebook): activate app before file dialog when no windows exist#676
Conversation
On macOS, when all windows are closed but the app stays running, clicking File > Open wouldn't display the file picker dialog. This is because macOS requires the app to be activated (brought to foreground) before showing an NSOpenPanel when the app has no windows. The fix adds NSApplication.activateIgnoringOtherApps_(true) before showing the dialog in the no-window fallback path. Fixes #481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the File > Open menu action when all windows are closed on macOS.
On macOS, when the last notebook window is closed, the app stays running due to the exit prevention logic. However, clicking File > Open from the menu bar wouldn't display the file picker dialog because macOS requires the app to be activated first when it has no windows.
The fix activates the app via
NSApplication.activateIgnoringOtherApps_(true)before showing the native file dialog in the no-window fallback path.Test plan
.ipynbfile and verify it opens in a new windowCloses #481
PR submitted by @rgbkrk's agent, Quill