-
Notifications
You must be signed in to change notification settings - Fork 1
feat: unified frame pipe — single channel, WASM demux, shared frame type constants #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
b310d73
07bf0b4
fb964f0
7d3b595
8123231
1550603
f46bf39
e4e993b
bc29c15
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -146,7 +146,7 @@ export function useDaemonKernel({ | |
| refreshBlobPort(); | ||
|
|
||
| const unlistenBroadcast = webview.listen<DaemonBroadcast>( | ||
| "daemon:broadcast", | ||
| "notebook:broadcast", | ||
| (event) => { | ||
| if (cancelled) return; | ||
|
Comment on lines
148
to
151
|
||
|
|
||
|
|
@@ -377,7 +377,7 @@ export function useDaemonKernel({ | |
| } | ||
|
|
||
| case "env_progress": | ||
| // Handled by useEnvProgress hook's own daemon:broadcast listener | ||
| // Handled by useEnvProgress hook's own notebook:broadcast listener | ||
| break; | ||
|
|
||
| case "env_sync_state": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup of Tauri event listeners doesn’t follow the repository’s established pattern of handling the
Promisereturned bylisten()with a.catch(() => {})to avoid unhandled rejections (seeapps/notebook/src/App.tsx:847-851). Consider updating theseunlisten*.then(...)calls (including the newly addedunlistenFrame) to also attach a catch handler.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — added
.catch(() => {})to all four unlisten calls in the cleanup.