Fix crashes when using the "--touch" option.#80
Merged
Conversation
Fix memory to be mapped read/write, so that the "touch" option can write to it. Signed-off-by: Patrick Mansfield <patrick.mansfield@cpacketnetworks.com>
patman-cp
commented
Sep 30, 2019
patman-cp
left a comment
patman-cp
left a comment
Contributor
Author
There was a problem hiding this comment.
The shmtest test script didn't work for me, I manually ran some simple tests with "--touch" commands, these:
./numactl --length=20m --shm=A --touch
./numactl --length 10485760 --file B --membind 1 --touch
Without the fix, both the above will seg fault.
|
This patch also fixes the issue for me (no more segfaults) |
Contributor
|
Thanks! |
Contributor
1 similar comment
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix memory to be mapped read/write, so that the "touch" option can write to it.
Signed-off-by: Patrick Mansfield patrick.mansfield@cpacketnetworks.com