Skip to content

chore: Use Rust implementation of Kafka source/sink in E2E tests #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BulkBeing
Copy link
Contributor

@BulkBeing BulkBeing commented May 27, 2025

  • Use Rust implementation of numaflow with builtin Kafka source/sink for E2E tests
  • Remove Kafka E2E tests with Redis as ISB

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.40%. Comparing base (6d673fd) to head (1bcd7a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2677      +/-   ##
==========================================
- Coverage   73.48%   73.40%   -0.08%     
==========================================
  Files         412      412              
  Lines       71748    71748              
==========================================
- Hits        52723    52666      -57     
- Misses      17908    17965      +57     
  Partials     1117     1117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BulkBeing BulkBeing marked this pull request as ready for review June 2, 2025 04:19
@BulkBeing BulkBeing requested review from whynowy and vigith as code owners June 2, 2025 04:19
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's wait for 1.5 release to merge this in? 1.5 is on golang data-plane

@BulkBeing BulkBeing marked this pull request as draft June 2, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants