-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
NEP: Drop Python2 support. #10006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP: Drop Python2 support. #10006
Conversation
3d1e652
to
23428a2
Compare
[ci skip]
23428a2
to
87349f6
Compare
|
||
If you are a NumPy user who requires ongoing Python2 support in 2020 or later, | ||
then please contact your vendor. If you are a vendor who wishes to continue to | ||
support NumPy on Python2 in 2020+, please get in touch; ideally we'd like you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a good place to add an link of some form (e.g., an email address for a core developer who could coordinate)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would just be the mailing list, I guess? I dunno, if you can't figure out how to contact the project then maybe you shouldn't be selling commercial support for numpy :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough!
to get involved in maintaining the LTS before it actually hits end of life so | ||
that we can make a clean handoff. | ||
|
||
To minimize disruption, running ``pip install numpy`` on Python 2 will continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matthias Bussonier suggested to make it "should continue", have no clue myself, doubt it matters too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2n's but yes :-) thanks. From experience with IPython many Python 2 users have an old verision of pip. Here is my download statistics analysis for IPython. Though with a good error message in setup.py (please upgrade pip
) it tend to get solved fast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should make that suggestion in the next release? It can't hurt to have it done before Python2 is dropped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, the pip version should be >= 9.
Anyway, I am good with putting this in with or without modifications. Should wait a week more or so to give everyone a chance to protest maybe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all OK to me - most important is that the dates are clear, and they are.
Just as a thought, if you bump version number and get a LTS you should likely have version 2.x be LTS and version 3.x be python 3 only. |
I'm putting this in now. We can update it if there are future changes. |
[ci skip]
I put a 1.14 milestone on this as I would like to include a reference in the release notes.