-
-
Notifications
You must be signed in to change notification settings - Fork 166
MAINT: Add CircleCI #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Add CircleCI #208
Conversation
good idea, +1
done |
@rgommers can you check https://circleci.com/gh/numpy/numpydoc/edit#advanced-settings And make sure "Build forked pull requests" is turned on? Or find a way to give me permissions for |
Oh wait, I was actually able to change it, never mind! |
Well that was way less painful than expected: https://3-11639513-gh.circle-artifacts.com/0/html/index.html Ready for review/merge from my end. |
Code LGTM. I'll leave it open for a bit to give others the chance to comment. I actually thought it did more than building the numpydoc readthedocs at first. What would be really helpful is to build the NumPy docs with it - that could show how things actually look; the numpydoc docs themselves are way too small for that. |
We could do something similar to sphinx-gallery, namely include in But maybe building Let's do that as a separate PR, though, since it's probably going to require a bit more work. |
Yes agree, a separate PR is better. Building NumPy docs will be less work and more benefit I think. It covers (almost) all cases I'd think. |
Merged, thanks @larsoner |
Hmm this failed:
|
I wanted to browse and link to built docs in #197 but didn't see a way to do it. This should make it easy to view hopefully.
I don't have permissions for the NumPy org to tick the box here to enable it:
https://circleci.com/add-projects/gh/numpy
@rgommers or some other suitably permissioned person, could you enable it? Then I can iterate here until it works.
Eventually this could easily probably amended to upload to
readthedocs
, not sure if it's already automated or not.