Simplify use of ISA specific routines through a unified API for static methods #143
Merged
sterrettm2 merged 9 commits intonumpy:mainfrom Apr 23, 2024
Merged
Simplify use of ISA specific routines through a unified API for static methods #143sterrettm2 merged 9 commits intonumpy:mainfrom
sterrettm2 merged 9 commits intonumpy:mainfrom
Conversation
sterrettm2
reviewed
Apr 8, 2024
Contributor
sterrettm2
left a comment
There was a problem hiding this comment.
Looks good! I just had a few comments I would like you to consider before merging it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies use avx512/avx2 specific methods via a single header file which when complied with the right AVX-512/AVX2 flags it calls the corresponding sort routines. Example:
When compiled with
-mavx512vl -mavx512dq, it calls theavx512_qsortroutine and when compiled with-mavx2it calls theavx2_qsort.Todo: