Adds support for AVX2 for 32-bit types for quicksort and quickselect#60
Merged
r-devulap merged 19 commits intonumpy:mainfrom Oct 24, 2023
Merged
Adds support for AVX2 for 32-bit types for quicksort and quickselect#60r-devulap merged 19 commits intonumpy:mainfrom
r-devulap merged 19 commits intonumpy:mainfrom
Conversation
3 tasks
sterrettm2
force-pushed
the
avx2-32bit
branch
from
bb03f6f to
58a4c08
Compare
sterrettm2
force-pushed
the
avx2-32bit
branch
5 times, most recently
from
663af1d to
f59b885
Compare
r-devulap
requested changes
Oct 20, 2023
Member
r-devulap
left a comment
r-devulap
left a comment
There was a problem hiding this comment.
Reviewed only changes in the common qsort file.
r-devulap
reviewed
Oct 20, 2023
r-devulap
reviewed
Oct 20, 2023
r-devulap
approved these changes
Oct 24, 2023
Member
r-devulap
left a comment
r-devulap
left a comment
There was a problem hiding this comment.
LGTM. Thank you @sterrettm2!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for AVX2 for 32-bit data types (int32_t, uint32_t, float) for quicksort and quickselect. It also includes benchmarks and tests for these. Below is a comparison of the performance: