Skip to content

feat: add programs.hlint #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023
Merged

feat: add programs.hlint #33

merged 1 commit into from
Jan 23, 2023

Conversation

teto
Copy link
Contributor

@teto teto commented Jan 23, 2023

style checker for haskell

style checker for haskell
@zimbatm zimbatm merged commit d5ed9a1 into numtide:master Jan 23, 2023
@zimbatm
Copy link
Member

zimbatm commented Jan 23, 2023

thanks!

@teto teto deleted the add-hlint branch January 23, 2023 11:30
@srid
Copy link
Contributor

srid commented Jan 24, 2023

@zimbatm This PR is interesting, because it deviates from the autoformating domain. hlint is not a formatter; more like a code linter. Is that in scope of treefmt? If so, I might open a PR to add haskell-language-server check (which checks that IDE support works) as well. However, this will require a slight change to the check output, to make it use the devshell's nativeBuildInputs, because HLS requires Haskell build tools (cf).

@zimbatm
Copy link
Member

zimbatm commented Jan 24, 2023

If it works as intended my practical side says that it's fine. We started using linters on some projects and it works surprisingly well. But it would be good to clarify linter usage upstream. In the docs, and maybe come up with a different name than "formatter" for the keys then. Let me know if you have some ideas in that area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants