Add GHA workflow, allow to select shell variant, add checks, etc.#6
Merged
Ecco merged 13 commits intonumworks:masterfrom Oct 9, 2019
Merged
Add GHA workflow, allow to select shell variant, add checks, etc.#6Ecco merged 13 commits intonumworks:masterfrom
Ecco merged 13 commits intonumworks:masterfrom
Conversation
This was referenced Oct 8, 2019
Ecco
reviewed
Oct 8, 2019
Contributor
Ecco
left a comment
Ecco
left a comment
There was a problem hiding this comment.
Great PR, thank you! Here are a few comments 😄
added 11 commits
October 8, 2019 22:34
Contributor
Author
|
@Ecco, I think I addressed all of your comments. Let me know if you find any other issue! |
Contributor
|
Excellent. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1
Close #2
releases/v1.@actions/coreis updated to^1.1.3.eslintis removed frompackage.json, because it is not usable without a configuration file.RUNNER_TMPis not empty.msysdo.cmdis first renamed tomsysdo.in(foruses: ./to work in the GHA workflow), but is then removed (by hardcoding it inindex.js).msystemis added to the action, to allow users to select the variant of MSYS2 to use. It defaults to MINGW64.test.sh) is added and it is tested four times in the workflow: one with each allowed value of MSYSTEM and one without setting it explicitly.