Skip to content

nushell.sh is incredibly slow #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
holly-hacker opened this issue Jan 12, 2023 · 4 comments · Fixed by #740
Closed

nushell.sh is incredibly slow #739

holly-hacker opened this issue Jan 12, 2023 · 4 comments · Fixed by #740

Comments

@holly-hacker
Copy link
Contributor

holly-hacker commented Jan 12, 2023

A few times, I have noticed that nushell.sh is incredibly slow to load (freezes my browser for at least 5 seconds on a desktop, more on a laptop). I decided to check why this is with chrome devtools and noticed that it does almost 1500(!) web requests. This seems to be because there are a massive amount of prefetch links. I included a small part of them , taken from here:

    <link rel="modulepreload" href="/assets/app.f134f4b4.js"><link rel="modulepreload" href="/assets/framework.3d018c9f.js"><link rel="modulepreload" href="/assets/2022-11-29-nushell-0.72.html.83fd61fb.js"><link rel="modulepreload" href="/assets/2022-11-29-nushell-0.72.html.798221e6.js"><link rel="prefetch" href="/assets/CONTRIBUTING.html.871cceeb.js" as="script" /><link rel="prefetch" href="/assets/index.html.d8190879.js" as="script" /><link rel="prefetch" href="/assets/2019-08-23-introducing-nushell.html.7430107c.js" as="script" /><link rel="prefetch" href="/assets/2019-09-24-nushell_0_3_0.html.59ca6e76.js" as="script" /><link rel="prefetch" href="/assets/2019-10-15-nushell-0_4_0.html.c3bbf53e.js" as="script" /><link rel="prefetch" href="/assets/2019-11-05-nushell-0_5_0.html.a9c29b1c.js" as="script" /><link rel="prefetch" href="/assets/2019-11-23-nushell-survey-results.html.62fdf43d.js" as="script" /><link rel="prefetch" href="/assets/2019-11-26-nushell-0_6_0.html.9b591d54.js" as="script" /><link rel="prefetch" href="/assets/2019-12-18-nushell-0_7_0.html.27aa64dc.js" as="script" /><link rel="prefetch" href="/assets/2019-12-31-happy-nu-year-2020.html.b10227fb.js" as="script" /><link rel="prefetch" href="/assets/2020-01-07-nushell-0_8_0.html.7e1f9684.js" as="script" /><link rel="prefetch" href="/assets/2020-01-28-nushell-0_9_0.html.5dffca6f.js" as="script" /><link rel="prefetch" href="/assets/2020-02-18-nushell-0_10_0.html.4f17778d.js" as="script" /><link rel="prefetch" href="/assets/2020-03-10-nushell_0_11_0.html.10ea3eda.js" as="script" /><link rel="prefetch" href="/assets/2020-03-31-nushell_0_12_0.html.b2593645.js" as="script" /><link rel="prefetch" href="/assets/2020-04-21-nushell_0_13_0.html.3c55d330.js" as="script" /><link rel="prefetch" href="/assets/2020-05-12-nushell_0_14_0.html.97025cd2.js" as="script" /><link rel="prefetch" href="/assets/2020-06-09-nushell_0_15_0.html.84c86196.js" as="script" /><link rel="prefetch" href="/assets/2020-06-30-nushell_0_16_0.html.31be5e65.js" as="script" /><link rel="prefetch" href="/assets/2020-07-21-nushell_0_17_0.html.ded6e3c7.js" as="script" /><link rel="prefetch" href="/assets/2020-08-11-nushell_0_18.html.64e14c69.js" as="script" /><link rel="prefetch" href="/assets/2020-08-23-year_of_nushell.html.fde65652.js" as="script" /><link rel="prefetch" href="/assets/2020-09-01-nushell_0_19.html.37959c59.js" as="script" />

Through some googling I figured this is because of vuepress' shouldPrefetch option is not configured: vuejs/vuepress#636

@rgwood
Copy link
Contributor

rgwood commented Jan 12, 2023

Good catch, thanks. What an insane default setting...

@fdncred
Copy link
Contributor

fdncred commented Jan 12, 2023

wow, thanks for tracking that down @holly-hacker. it seems to make a big change after @rgwood's PR. really appreciate this!

@holly-hacker
Copy link
Contributor Author

Thanks for the speedy fix! :)

@loneicewolf
Copy link

Thanks @holly-hacker and @rgwood ! this was a amazing difference ⚡
a bit late reply; I know. 🫖 🍵

ayax79 pushed a commit to ayax79/nushell.github.io that referenced this issue Jun 26, 2024
updates using the spread operator

Co-authored-by: nash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants