moveMouse refactor to use sendInput on Windows (#26) #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reiss-Cashmore
changed the title
|
By the looks of it, it failed because it's worried about some type coercion and loss of data through the casting. I'll need to probably read up a bit as I really don't know C++ very well |
s1hofmann
requested changes
Oct 10, 2021
There was a problem hiding this comment.
Hi @Reiss-Cashmore 👋
Looking good overall, I just added a few small remarks.
Thanks for contributing!
Make Absolute coord calculation return MMPoint
|
Pipelines completed, your change is available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR should nicely refactor the moveMouse method
Ref: #26
I believe everything here is inline with the Microsoft documentation and guidelines here
https://docs.microsoft.com/en-us/windows/win32/api/winuser/ns-winuser-mouseinput
There might still be some flags worth exploring and dwExtraInfo but I am not too sure
Not sure if you want the helper methods for converting the points to absolute coords to live within mouse.c