Skip to content

fix(module): move aliases to preset #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
farnabaz merged 2 commits into from
Nov 30, 2020
Merged

fix(module): move aliases to preset #184

farnabaz merged 2 commits into from
Nov 30, 2020

Conversation

@farnabaz
Copy link
Collaborator

@farnabaz farnabaz commented Nov 29, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Because storybook run presets before main.js, the aliases are not available in addons.

close #152

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@farnabaz farnabaz mentioned this pull request Nov 30, 2020
Closed
@farnabaz farnabaz changed the title fix(module): move aliases to preset so addons can use them fix(module): move aliases to preset Nov 30, 2020
@farnabaz farnabaz merged commit 33beee1 into master Nov 30, 2020
@farnabaz farnabaz deleted the aliases-in-preset branch November 30, 2020 16:55
@farnabaz farnabaz mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Components with mixins are not rendering the props table correctly

2 participants

@farnabaz