-
-
Notifications
You must be signed in to change notification settings - Fork 688
fix(transformers): opt-in to correct extensions
spelling
#1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transformers): opt-in to correct extensions
spelling
#1213
Conversation
|
Name | Link |
---|---|
π¨ Latest commit | 2733907 |
β¦king-change-extensions
Hm I wanted to revert the other commit but have done something wrong π¬ |
This reverts commit adc0143.
Okay should be good |
That you a lot @harlan-zw π Should've renamed the original PR, this is my bad! The new test is a great addition as well! |
I would just like to double-check with @atinux and @farnabaz about keeping that I think no one (or very few people) yet used these features, avoiding preserving that kind of dead code could be great... even if I understand the concerns about semantic versioning. |
I agree that no one yet used this feature, also we do not have good documentation about parsers and transformers. Transformers are mainly used internally, We did not expose types and a helper to create custom transformers yet. So I see no harm in dropping misspelled key. It will be good if we create/expose util to define transformers. like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the @deprecated
keys and support for previous implementation?
I would like to preserve the test-case there, but not the support for older implementations (point about this in discussion with @farnabaz above).
I'll make a seperate pr for the test case if not needed π |
Great idea |
π Linked issue
Related #1204 (comment)
β Type of change
π Description
This is an alternative solution to the fix for mispelled extensions, this PR reverts the breaking change commit of #1204 (comment). We prefer to use a soft breaking change to avoid having to bump majors.
I've also included a test for a custom transformer here using the deprecated key.
π Checklist