Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

refactor(nuxt): add import protection to nitro config #5847

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/content#1346 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

While investigating nuxt/content#1346 (comment) (resolved with nitrojs/nitro#335), I think it doesn't make sense to add this in a hook when we can add it directly. Additional plus is that users get the plugin in nitro:config hook.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 July 12, 2022 09:12
@danielroe danielroe self-assigned this Jul 12, 2022
@netlify
Copy link

netlify bot commented Jul 12, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit b62f1fe
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62cd3b01b5af8b00093109c7

@netlify
Copy link

netlify bot commented Jul 12, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit a0bda70
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62cd40e10f710300099dcce6

@pi0 pi0 merged commit 1840b96 into main Jul 12, 2022
@pi0 pi0 deleted the refactor/import-config branch July 12, 2022 10:55
@pi0 pi0 mentioned this pull request Jul 12, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants