Skip to content

fix(tpc): respect script location and action field#105

Merged
harlan-zw merged 7 commits into
mainfrom
fix/respect_tpc_location_and_action
Jun 25, 2024
Merged

fix(tpc): respect script location and action field#105
harlan-zw merged 7 commits into
mainfrom
fix/respect_tpc_location_and_action

Conversation

@huang-julien
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

This PR make the generation of TPC composables respect the location and the position of scripts to add.

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scripts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 0:01am
scripts-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 0:01am

@huang-julien huang-julien marked this pull request as ready for review June 24, 2024 11:32
Copy link
Copy Markdown
Contributor

@flashdesignory flashdesignory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at least the script location / action field assignment 😄

@harlan-zw harlan-zw merged commit 6d002c2 into main Jun 25, 2024
@harlan-zw harlan-zw deleted the fix/respect_tpc_location_and_action branch June 25, 2024 02:22
zizzfizzix pushed a commit to zizzfizzix/nuxt-scripts that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants