Skip to content

refactor: refactor import { type foo } to import type { foo }#108

Merged
harlan-zw merged 2 commits into
nuxt:mainfrom
shinGangan:refactor/import-types
Jun 24, 2024
Merged

refactor: refactor import { type foo } to import type { foo }#108
harlan-zw merged 2 commits into
nuxt:mainfrom
shinGangan:refactor/import-types

Conversation

@shinGangan
Copy link
Copy Markdown
Contributor

@shinGangan shinGangan commented Jun 23, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

import type { foo } and import { type foo } were mixed, so I refactored it to import type { foo }.

Note

Refactoring after the official release is hard, so I fixed it first.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 23, 2024

@shinGangan is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

@shinGangan shinGangan changed the title refactor: refactor import { type foo } to `import type { foo } refactor: refactor import { type foo } to import type { foo } Jun 23, 2024
@harlan-zw
Copy link
Copy Markdown
Collaborator

Thanks! Ideally, the nuxt eslint rules would cover this.

@harlan-zw harlan-zw merged commit abce2c0 into nuxt:main Jun 24, 2024
@shinGangan
Copy link
Copy Markdown
Contributor Author

shinGangan commented Jun 24, 2024

Thanks! Ideally, the nuxt eslint rules would cover this.

@harlan-zw , I feel the same way.
Nuxt ESLint has rules set, so the problem may be with the typescript-eslint rules themselves.
(Can it not be detected in a case like this?🤔)

I'll also look into the rules of typescript-eslint when I have time.

@shinGangan shinGangan deleted the refactor/import-types branch June 24, 2024 05:57
zizzfizzix pushed a commit to zizzfizzix/nuxt-scripts that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants