Skip to content

chore: update nuxt-module-builder to 0.8.0#110

Merged
harlan-zw merged 2 commits into
mainfrom
fix/vimeo
Jun 25, 2024
Merged

chore: update nuxt-module-builder to 0.8.0#110
harlan-zw merged 2 commits into
mainfrom
fix/vimeo

Conversation

@huang-julien
Copy link
Copy Markdown
Member

🔗 Linked issue

#92

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

package update with a build fix

@huang-julien huang-julien requested a review from harlan-zw June 24, 2024 17:14
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scripts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:25pm
scripts-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:25pm

@@ -1,5 +1,5 @@
import { watch } from 'vue'
import type Vimeo from 'vimeo__player'
import type Vimeo from '@vimeo/player'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursed vimeo 😆

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursed indeed 😩

@harlan-zw
Copy link
Copy Markdown
Collaborator

This won't fix #92 akaik? The module options will still be broken for the registry key.

@harlan-zw harlan-zw merged commit 4687a75 into main Jun 25, 2024
@harlan-zw harlan-zw deleted the fix/vimeo branch June 25, 2024 02:09
@huang-julien
Copy link
Copy Markdown
Member Author

huang-julien commented Jun 25, 2024

Yeah, will look and fix it today :)

zizzfizzix pushed a commit to zizzfizzix/nuxt-scripts that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants