Skip to content

test: e2e integration tests for ga and gtm#189

Merged
harlan-zw merged 5 commits into
mainfrom
tests/e2etpc
Aug 5, 2024
Merged

test: e2e integration tests for ga and gtm#189
harlan-zw merged 5 commits into
mainfrom
tests/e2etpc

Conversation

@huang-julien
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Following differents versions of nuxt-scripts that had issues with gtm and ga. This PR aims to add e2e tests and verify that GTM and GA are correctly sending events to google.

@flashdesignory the GTM test isn't working because G-TEST is not available (404 when requesting the script). Anyway, we need an id for both GA and GTM 😅 i prefer to avoid always pushing events and blowing up @harlan-zw 's dashboard at each PR.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scripts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 5:23am
scripts-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 5:23am

@harlan-zw
Copy link
Copy Markdown
Collaborator

FWIW my dashboard is only made for testing Nuxt Scripts so blow it up all you want

@harlan-zw harlan-zw merged commit d730eb5 into main Aug 5, 2024
@harlan-zw harlan-zw deleted the tests/e2etpc branch August 5, 2024 05:40
zizzfizzix pushed a commit to zizzfizzix/nuxt-scripts that referenced this pull request Mar 5, 2026
Co-authored-by: harlan <harlan@harlanzw.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants