Skip to content

fix(bundling): throw error if download fails #253

Merged
harlan-zw merged 2 commits into
mainfrom
fix/bundle_throw_if_fail
Sep 8, 2024
Merged

fix(bundling): throw error if download fails #253
harlan-zw merged 2 commits into
mainfrom
fix/bundle_throw_if_fail

Conversation

@huang-julien
Copy link
Copy Markdown
Member

🔗 Linked issue

fix #233

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR stops the build process if a script download fails

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scripts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 8:41pm
scripts-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 8:41pm

@harlan-zw harlan-zw changed the title fix: stop build process if scripts fails to be downloaded for bundle fix: throw error if download fails when bundling Sep 8, 2024
@harlan-zw harlan-zw changed the title fix: throw error if download fails when bundling fix(bundling): throw error if download fails Sep 8, 2024
@harlan-zw harlan-zw merged commit 69e6d8f into main Sep 8, 2024
@harlan-zw harlan-zw deleted the fix/bundle_throw_if_fail branch September 8, 2024 00:43
zizzfizzix pushed a commit to zizzfizzix/nuxt-scripts that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bundle from local npm instead of external unpkg.com to prevent connection error

2 participants