feat: add option to display framework icon

[undead-voron]

No description provided.

[atinux]

Could you share a video about the result please?

[undead-voron]

icon_change.mp4

@atinux

Checked following stuff:

• brand icons are disabled by default
• checked brand icons on different frameworks
• checked that brand icons will return to default for opened tabs after feature is disabled
• checked brand icons when multiple tabs are active
• checked that tab state is saved after service worker has been deactivated

[undead-voron]

@atinux
I think I can't edit reviewers for this pull request. Can you add yourself as reviewer or should I close this pr and create a new one?

[atinux]

Nice work @undead-voron and sorry for late answer I was on vacation.

I think we can display the icons by default and remove the ability to choose, this way we don't need to add the storage permission. Happy to update your PR?

[undead-voron]

Sure @atinux . Please, update it if you got time.

[undead-voron]

@atinux
I think that we need to have storage permission anyway. As far as chrome extension has service worker in manifest version 3 (contrary to background page in manifest version 2 ) we need to store tabs state in storage (otherwise there would be no info in popup after service worker terminates).

[atinux]

I see, don't have much time right now.

I think we can keep storage but removing the settings to display the icons by default, I prefer this new behavior :)

[undead-voron]

Sounds great!

[undead-voron]

Hi @atinux
I had some free tine to removed settings UI for choosing framework icon and make framework icon to be displayed by default.
here are the commits
567f408
e036bcc
4cc3cdb

please, review current pr one more time, when you got time for it