Skip to content

Conversation

@dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jun 5, 2025

Description

fixes #2236
fixes #2237

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
…the env as a transitive dep, but we depend on it directly)

Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Run pipeline against all rows

Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv dagardner-nv requested a review from willkill07 July 8, 2025 22:11
Signed-off-by: David Gardner <[email protected]>
@dagardner-nv dagardner-nv requested a review from hsin-c July 9, 2025 16:30
Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the code changes, documentation, and other improvements look good (based off of changes since my last review)

Copy link
Contributor

@hsin-c hsin-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving the comments, all looks good to me.

@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Review - Approved in Morpheus Boards Jul 9, 2025
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b99e63d into nv-morpheus:branch-25.06 Jul 9, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from Review - Approved to Done in Morpheus Boards Jul 9, 2025
@dagardner-nv dagardner-nv deleted the david-tzm-dlp branch July 9, 2025 19:31
@dagardner-nv dagardner-nv restored the david-tzm-dlp branch July 14, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Non-breaking change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: write_df_to_file does not support PAQUET [BUG]: Serializing a cuDF DataFrame with struct columns results in loosing keys

4 participants