-
-
Notifications
You must be signed in to change notification settings - Fork 713
Minor improvements to the PR template #17782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SaschaCowley - can you resolve conflicts |
@seanbudd done |
seanbudd
reviewed
May 19, 2025
projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Budd <[email protected]>
seanbudd
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conceptApproved
Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #17616
Summary of the issue:
There is inconsistent use of colons (":") after prompts in the PR template.
Description of user facing changes
Description of development approach
Read templates and made adjustments as necessary.
Read the template documentation, making minor fixes and documenting the new section.
Testing strategy:
Proof-read templates.
Known issues with pull request:
Users may dislike the change
Code Review Checklist:
@coderabbitai summary