Support sheband and tangle mode header tag #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristijanhusak
force-pushed
the
support_sheband_and_tangle_mode_header_tag
branch
from
113cc16 to
67667a8
Compare
SjB
force-pushed
the
support_sheband_and_tangle_mode_header_tag
branch
from
67667a8 to
160fe5f
Compare
lua/orgmode/babel/tangle.lua
Outdated
Comment on lines
83
to
87
| local shebang = info.header_args[':shebang'] | ||
| if shebang then | ||
| shebang = shebang:gsub('[\'"]', '') | ||
| table.insert(parsed_content, 1, shebang) | ||
| end |
There was a problem hiding this comment.
This logic is already done above on line 64. Is there a reason why it's needed twice?
lua/orgmode/babel/tangle.lua
Outdated
| if mode_str and mode_str:sub(1, 1) == 'o' then | ||
| mode_str = mode_str:sub(2) | ||
| local mode_num = tonumber(mode_str, 8) | ||
| vim.loop.fs_chmod(filename, mode_num) |
There was a problem hiding this comment.
Instead of doing chmod after the file is created, lets pass down the mode as an argument to utils.writefile and pass it there when creating the file.
There was a problem hiding this comment.
sound good, I'm make the changes
Add the ability to include a shebang line at the beginning of tangled code files by supporting the `:shebang` header argument. The shebang value is cleaned of quotes and inserted as the first line of the tangled content.
This header allow the creator to change the generated file permissions.
When tangling code blocks to files, automatically create parent directories when the :mkdirp header argument is set to 'yes'.
Coding style requires single quotes
Add the ability to include a shebang line at the beginning of tangled code files by supporting the `:shebang` header argument. The shebang value is cleaned of quotes and inserted as the first line of the tangled content.
They keep showing up.
SjB
force-pushed
the
support_sheband_and_tangle_mode_header_tag
branch
from
e84d8a8 to
fdfb3c8
Compare
|
The orgmode docs describe 3 styles of tangle-mode values: ls-style, chmod style, and octal. All three style are now supported, however, I'm still using the example of the three modes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add shebang and tangle-mode source block header tags
Related Issues
New features to enable features in org-mode
Related #
https://orgmode.org/manual/Extracting-Source-Code.html
Closes #
Changes
Changes the structure of the tangle_info table.