Skip to content

vim.ui.open #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alex-courtis opened this issue Sep 24, 2023 · 1 comment · Fixed by #2912
Closed

vim.ui.open #2430

alex-courtis opened this issue Sep 24, 2023 · 1 comment · Fixed by #2912
Labels
feature request

Comments

@alex-courtis
Copy link
Member

alex-courtis commented Sep 24, 2023 •
edited
Loading

vim.ui.open handles OS specific system open: https://github.com/neovim/neovim/blob/b8103eece30dab8add09e134820b690d9fd00330/runtime/lua/vim/ui.lua

Not yet released.

Migrate system_open to use that. This may be an opinionated migration; adding this by default is desirable.

Normalise the OS detection feature flags as per https://github.com/nvim-tree/nvim-tree.lua/wiki/Development#os-feature-flags
@alex-courtis alex-courtis mentioned this issue Sep 24, 2023
Closed
@alex-courtis
Copy link
Member Author

Added in 0.10

This could be version feature flagged.

alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
feat(#2430): use vim.ui.open as default system_open, for neovim 0.10+
275b001
@alex-courtis alex-courtis mentioned this issue Sep 14, 2024
Merged
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
feat(#2430): use vim.ui.open as default system_open, for neovim 0.10+
596a24b
alex-courtis added a commit that referenced this issue Sep 14, 2024
@alex-courtis
feat(#2430): use vim.ui.open as default system_open, for neovim 0.10+ (…
03f737e 
…#2912)

* feat(#2430): use vim.ui.open as default system_open, for neovim 0.10+

* feat(#2430): use vim.ui.open as default system_open, for neovim 0.10+
@github-actions github-actions bot mentioned this issue Sep 14, 2024
Merged
@github-actions github-actions bot mentioned this issue Nov 11, 2024
Open
@github-actions github-actions bot mentioned this issue Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#2430): use vim.ui.open as default system_open, for neovim 0.10+ nvim-tree/nvim-tree.lua
1 participant
@alex-courtis