Skip to content

Conversation

@knubie
Copy link
Contributor

@knubie knubie commented Apr 2, 2022

The PR adds an hl_group named NvimTreeFileIcon which is used similarly to NvimTreeFolderIcon. It changes the color of file icons without the use of nvim-web-devicons.

Closes #1124

@alex-courtis
Copy link
Member

Tested and working when nvim-web-devicons not loaded. Does nothing when loaded, as expected.

@alex-courtis
Copy link
Member

I've had a look at #284; we could have NvimTreeFileIcon hl_group override the one returned by web_devicons.get_icon.

We could do it with an option, or just do it if NvimTreeFileIcon exists.

Thoughts @kyazdani42 ?

Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now i get it 😄

@kyazdani42
Copy link
Member

could you run a luacheck please ?

@knubie
Copy link
Contributor Author

knubie commented Apr 3, 2022

@kyazdani42 Sure. I just updated the branch with the luacheck fixes.

@kyazdani42 kyazdani42 merged commit 924aa29 into nvim-tree:master Apr 4, 2022
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing the color of file icons

3 participants