feat: Support diagnostics severity #1755
Conversation
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Fantastic idea, I think I will be using info.
| local buffer_severity = {} | ||
|
|
||
| for _, diagnostic in ipairs(vim.diagnostic.get()) do | ||
| for _, diagnostic in ipairs(vim.diagnostic.get(nil, { severity = M.severity })) do |
There was a problem hiding this comment.
This is showing only the diagnostics with that exact severity.
:help diagnostic-severity indicates that you will need to set a min level.
There was a problem hiding this comment.
That's correct I'll the default value to { min = vim.diagnostic.severity.HINT }. But I think it's good to keep it like that here so it becomes compatible with other functions that uses severity as an options as per the docs. Example below. What do you think? ^^
1. A single [vim.diagnostic.severity](https://neovim.io/doc/user/diagnostic.html#vim.diagnostic.severity) value:
vim.diagnostic.get(0, { severity = vim.diagnostic.severity.WARN })
2. A table with a "min" or "max" key (or both):
vim.diagnostic.get(0, { severity = { min = vim.diagnostic.severity.WARN } })
There was a problem hiding this comment.
We could simply make it explicit in the config and pass it directly to get()
diagnostics = {
severity = {
min = vim.diagnostic.severity.HINT,
max = vim.diagnostic.severity.ERROR,
},
}This configuration will be validated at setup time.
There was a problem hiding this comment.
Perfect ^^ I'll do it like that. Thanks!
doc/nvim-tree-lua.txt
Outdated
| enable = false, | ||
| show_on_dirs = false, | ||
| debounce_delay = 50, | ||
| severity = null, |
There was a problem hiding this comment.
Please run update-help.sh as per https://github.com/nvim-tree/nvim-tree.lua/blob/master/CONTRIBUTING.md
This will set the default value.
iabdelkareem
requested review from
alex-courtis and
gegoune
and removed request for
alex-courtis
|
Thank you! Glad you liked the idea ^^ I updated the PR according to the comments. |
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Tested OK.
Tidied the doc a little.
| }, | ||
| notify = { | ||
| threshold = vim.log.levels.INFO, | ||
| }, |
There was a problem hiding this comment.
Not sure why this was out of order...
|
Thanks—this is invaluable. |
4 participants
Resolves #1756