-
-
Notifications
You must be signed in to change notification settings - Fork 625
refactor(#2826): multi instance view #3109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apologies @raaymax I abandoned trying to rebase #2864 , I applied the changes by hand. Notable:
I'd be most grateful for your review; any problems you remember would be good to check. |
|
This is working, however it's not useful due to the extensive use of the globals. Alternative approach: extract the global functions into a separate global module, to be addressed in the next milestone. |
Needs a re-think and alternative approach. |
fixes #2826
View does not mutate options, hence no need to deep clone anything.
Preserved the tab states bits; they still function as there is still one and only one explorer.
Testing methodology:
error("$callsite")
at each call to a View method