Windows linebreaks in .nvmrc causes errors

[mearns]

If the .nvmrc file has a trailing windows-style linebreak (CR+LF), the version is not read correctly. Specifically, the CR is treated as part of the version string.

$ uname -a
Linux ubuntuTemplate 3.13.0-24-generic #47-Ubuntu SMP Fri May 2 23:30:00 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
$ echo -e "v5.5.0\r\n" > .nvmrc
$ nvm use
>ound '/opt/fountain/.nvmrc' with version <v5.5.0
" is not yet installed

I realize windows as a platform isn't supported, but it's not too exceptional to have files created or edited in windows and used on linux or mac, and it's non-trivial to not have a trailing CR+LF on a text file edited in windows. Stripping all trailing whitespace from the version read from .nvmrc would resolve the problem.

[ljharb]

I'm mystified how this would come up, since anyone editing an .nvmrc should, as you point out, be on linux or mac - but I agree it's a trivial problem to fix. Thanks!

[wrumsby]

I'm mystified how this would come up

If your project has an EditorConfig file that sets end_of_line = crlf this could come up.

[ljharb]

good lord, why would you have that tho. 🔥 all the crlfs 🔥