Remove nospace in bash_completion, space is helpful #1456
Conversation
| @@ -92,5 +92,5 @@ if [[ -n ${ZSH_VERSION-} ]]; then | |||
| autoload -U +X bashcompinit && bashcompinit | |||
| fi | |||
|
|
|||
| complete -o default -o nospace -F __nvm nvm | |||
| complete -o default -F __nvm nvm | |||
There was a problem hiding this comment.
Can you elaborate on what this change does and why it's preferred?
There was a problem hiding this comment.
If you type nvm a[tab it'll give you only nvm alias, so if you want to keep entering the next parameter, you'll need to manually add another space here, then you can press [tab] again, or it'll not work. By removing -o no space, the same situation, it'll give you nvm alias , and you can directly press the next [tab] for the next parameter, that's what most of the bash_completions doing, I don't know why we should disable it here.
There was a problem hiding this comment.
Hmm - I feel like that might be safer, in that you can't accidentally tab through more than one argument.
There was a problem hiding this comment.
That's not what the other bash_completions doing, will be special case, which makes no sense, as the previous PR, you can try curl --compr[tab] or git --vers[tab], they'll give you the space.
ljharb
force-pushed
the
bash_completion-space
branch
from
f0eea84 to
676fff0
Compare
No description provided.