Skip to content

Also unset NVM_RC_VERSION when unloading #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2017
Merged

Also unset NVM_RC_VERSION when unloading #1607

merged 1 commit into from
Sep 8, 2017

Conversation

zeorin
Copy link
Contributor

@zeorin zeorin commented Sep 7, 2017

nvm_unload was unsetting RC_VERSION instead of NVM_RC_VERSION. Am I correct in thinking this was a typo?

ljharb
ljharb approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like this was introduced in 744507b, and so it's never been correct.

@ljharb ljharb merged commit 44ab611 into nvm-sh:master Sep 8, 2017
@ljharb ljharb added the bugs Oh no, something's broken :-( label Sep 8, 2017
@zeorin zeorin deleted the unload-fix branch September 9, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bugs Oh no, something's broken :-(
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeorin @ljharb