Add --alias and --default to Install #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For: `nvm install 8.12.0` after install: --alias=8 is equivalent to `nvm alias 8 8.12.0` --default is equivalent to `nvm alias default 8.12.0` Co-authored-by: Kayla Altepeter <[email protected]> Co-authored-by: Dena Burd <[email protected]> Co-authored-by: Jordan Harband <[email protected]>
gitburd
force-pushed
the
install-alias2
branch
2 times, most recently
from
210767f to
ffaf577
Compare
|
@gitburd thanks - in the future, if you paste a link to your branch, I can pull in the changes for you. Creating multiple PRs leaves orphaned refs unless I manually keep them both in sync. |
ljharb
requested changes
Aug 1, 2020
|
k, fixed the two new tests; the LTS test was failing because |
ljharb
approved these changes
Aug 2, 2020
ljharb
added
feature requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1867
This is a follow up the work in PR #1929
I could not push to @kaltepeter 's remote so I have made a new PR.
Issue :
Tests:
ran with:
--alias=* version--alias=* no-version--default --alias=* versionDoes not return err
--alias=* version --default