Skip to content

Allow installation from other repository #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2021
Merged

Allow installation from other repository #2394

merged 1 commit into from
Jan 6, 2021

Conversation

nmarghetti
Copy link
Contributor

No description provided.

@ljharb ljharb added the installing nvm Problems installing nvm itself label Jan 1, 2021
ljharb
ljharb reviewed Jan 1, 2021
View reviewed changes
@nmarghetti nmarghetti force-pushed the install_other_repo branch 4 times, most recently from b08d1f7 to d647c57 Compare January 1, 2021 23:37
@nmarghetti
Copy link
Contributor Author

By the way, this change is in my other PR also, not sure if it is worth doing it in a separate pull request...

@ljharb
Copy link
Member

ljharb commented Jan 2, 2021

I think landing it separately and rebasing your PR is the best approach.

@as-orlov
Copy link

as-orlov commented Jan 2, 2021

Ok

@nmarghetti
Copy link
Contributor Author

I just found something weird.
I made a mistake in install.sh:
NVM_GITHUB_REPO="${NVM_INSTALL_GITHUB_REPO:-nvm-sh}"
It should be
NVM_GITHUB_REPO="${NVM_INSTALL_GITHUB_REPO:-nvm-sh/nvm}"
But the unit test still works.
I dont get it....

@nmarghetti nmarghetti force-pushed the install_other_repo branch 6 times, most recently from d1ba238 to 3d007c8 Compare January 2, 2021 14:10
@nmarghetti
Copy link
Contributor Author

Whatever I do in the install_script test suite, even 'exit 1', the tests still pass...

@nmarghetti nmarghetti force-pushed the install_other_repo branch 10 times, most recently from 4a106d2 to 18515f8 Compare January 2, 2021 15:03
@nmarghetti nmarghetti force-pushed the install_other_repo branch 22 times, most recently from d15c0dc to 585325d Compare January 2, 2021 21:09
@nmarghetti
Copy link
Contributor Author

I finally found out what was the problem. In test/install_script, nvm_install_with_aliased_dot and nvm_install_with_node_version were installing nvm using the travis build directory (due to NVM_DIR="${TRAVIS_BUILD_DIR}" in .travis.yml), so it was updating the git repository to the latest version of nvm, loosing all the changes from all the PR done after last release.

@nmarghetti nmarghetti requested a review from ljharb January 2, 2021 21:15
ljharb
ljharb reviewed Jan 4, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one small change.

@nmarghetti nmarghetti requested a review from ljharb January 4, 2021 22:45
@ljharb ljharb force-pushed the install_other_repo branch from 6ab4556 to 4e9df33 Compare January 6, 2021 21:02
@ljharb ljharb merged commit 4e9df33 into nvm-sh:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

+1 more reviewer

@as-orlov as-orlov as-orlov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
installing nvm Problems installing nvm itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmarghetti @ljharb @as-orlov