Skip to content

Conversation

emparq
Copy link

@emparq emparq commented Oct 31, 2015

Should be using -f if checking for a file.

Should be using `-f` if checking for a file.
@ljharb
Copy link
Member

ljharb commented Oct 31, 2015

This appears to be failing every "without curl" installation test.

@emparq
Copy link
Author

emparq commented Oct 31, 2015

That's odd. Though I'm pretty sure those failures have nothing to do with this 1-liner, seeing as how it's an isolated if/else where echo is the only thing performed.

-  if [ -d "$NVM_DIR/nvm.sh" ]; then
+  if [ -f "$NVM_DIR/nvm.sh" ]; then
     echo "=> nvm is already installed in $NVM_DIR, trying to update the script"
   else
     echo "=> Downloading nvm as script to '$NVM_DIR'"
   fi

@ljharb
Copy link
Member

ljharb commented Oct 31, 2015

That is a very good point. The failures are definitely unrelated to your change. Please rebase on top of latest master, and I'll merge it in.

@ljharb ljharb added the needs rebase Please rebase your branch onto latest master! This removes merge commits, & keeps the git log clean. label Nov 5, 2015
@ljharb ljharb closed this in 91ce41b Dec 22, 2015
@ljharb ljharb added the installing node Issues with installing node/io.js versions. label Dec 22, 2015
@emparq
Copy link
Author

emparq commented Dec 22, 2015

Oh, hey- my bad. Sorry I didn't see the rest of your comment requesting a rebase. Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installing node Issues with installing node/io.js versions. needs rebase Please rebase your branch onto latest master! This removes merge commits, & keeps the git log clean.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants