Update nvm.sh #899
Merged
Update nvm.sh #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterDaveHello
force-pushed
the
patch-2
branch
from
820a5e5 to
da2a3fc
Compare
| @@ -1616,10 +1616,12 @@ nvm() { | |||
| if [ "_$NVM_OS" = "_freebsd" ]; then | |||
| # node.js and io.js do not have a FreeBSD binary | |||
| nobinary=1 | |||
| echo "Currently, there is no binary for $NVM_OS" | |||
There was a problem hiding this comment.
these both should echo to stderr, not stdout
There was a problem hiding this comment.
Ok, working on it.
|
This seems like a good approach. |
PeterDaveHello
force-pushed
the
patch-2
branch
from
da2a3fc to
8ae4a43
Compare
|
Updated! |
|
Your description says "return nonzero" but this PR doesn't achieve that - I think just the error message is sufficient tho. Do you agree? |
PeterDaveHello
force-pushed
the
patch-2
branch
from
8ae4a43 to
5516f59
Compare
|
@ljharb my fault, that's the previous version of that commit before review, thanks for your prompt reply. |
Merged
|
@ljharb is this good to merge? Thanks. |
|
The tests were failing because of an SSL issue with |
|
Of course, give me few mins. |
PeterDaveHello
force-pushed
the
patch-2
branch
from
5516f59 to
2a174d0
Compare
Add prompt when there is no binary for node version greater than v1.0.0 Currently, on FreeBSD, if we try `nvm install 4.2`, we will only get: > Installing node v1.0 and greater from source is not currently supported In fact I had no idea what's wrong because I didn't use `-s` parameter for it, and then I found that there are two reasons: 1. There was no pre-built nodejs binary from official for FreeBSD, which means we need to build from source. 2. nvm doesn't support build for v1.0 and greater version from source yet. So I think there should be a prompt message to tell the user about the reason why nvm will go to build from source, no matter it will succeed or fail.
|
@ljharb Updated! |
ljharb
added a commit
that referenced
this pull request
Dec 5, 2015
[install] on install, indicate that there's no binary for FreeBSD
ljharb
added
OS: FreeBSD / OpenBSD
installing node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add prompt and return non-zero when there is no binary for node version greater than v1.0.0
Currently, on FreeBSD, if we try
nvm install 4.2, we will only get:In fact I had no idea what's wrong because I didn't use
-sparameter for it,and then I found that there are two reasons:
So I think there should be a prompt message to tell the user about the reason why nvm will go to build from source, no matter it will succeed or fail.