Pinning svelte to 3.44.2 to resolve a max call stack exceeded issue #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nylas/components/6vNvpTFznbKXQmmWA5wJAyZJ16Qm |
AaronDDM
requested review from
yifanplanet,
a team and
gudsson
and removed request for
a team
yifanplanet
approved these changes
Mar 29, 2022
gudsson
suggested changes
Apr 7, 2022
There was a problem hiding this comment.
{@const} wasn't introduced until Svelte 3.46 and is causing a build failure
|
Thanks @gudsson , we're seeing if we can get sveltejs/svelte#7397 merged to get this resolved instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Related to the following reported issue sveltejs/svelte#7032
Code changes
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.