Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

[develop] Expose lookup commitments #110

Merged
merged 5 commits into from
Aug 21, 2023
Merged

[develop] Expose lookup commitments #110

merged 5 commits into from
Aug 21, 2023

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Aug 15, 2023 •
edited
Loading

Related to o1-labs/o1js#1070

@dannywillems dannywillems requested a review from a team as a code owner August 15, 2023 18:32
@dannywillems dannywillems mentioned this pull request Aug 15, 2023
Merged
1 task
@dannywillems dannywillems changed the title Expose lookup commitments [develop] Expose lookup commitments Aug 15, 2023
@dannywillems dannywillems force-pushed the dannywillems/expose-lookup-commitments branch from f13f230 to 9bcfe02 Compare August 15, 2023 18:46
@dannywillems dannywillems mentioned this pull request Aug 15, 2023
Closed
dannywillems
dannywillems commented Aug 16, 2023
View reviewed changes
dannywillems
dannywillems commented Aug 16, 2023
View reviewed changes
rbonichon
rbonichon approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rbonichon
rbonichon approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the var declaration could (should?) be converted to let.

However, functionality-wise, that's good to me.

@dannywillems dannywillems mentioned this pull request Aug 16, 2023
Open
@dannywillems
Copy link
Member Author

Most of the var declaration could (should?) be converted to let.

However, functionality-wise, that's good to me.

let is not supported by jsoo.

@dannywillems dannywillems mentioned this pull request Aug 17, 2023
Open
@dannywillems
Copy link
Member Author

Most of the var declaration could (should?) be converted to let.
However, functionality-wise, that's good to me.

let is not supported by jsoo.

Will be supported when bumping jsoo, see #117.

@dannywillems dannywillems force-pushed the dannywillems/expose-lookup-commitments branch from 1acf7f4 to 3774539 Compare August 21, 2023 17:28
@dannywillems dannywillems force-pushed the dannywillems/expose-lookup-commitments branch from 3774539 to 94cfb4c Compare August 21, 2023 17:36
@dannywillems dannywillems force-pushed the dannywillems/expose-lookup-commitments branch from 94cfb4c to b15734d Compare August 21, 2023 18:09
@dannywillems dannywillems merged commit 4dd9c39 into develop Aug 21, 2023
@dannywillems dannywillems deleted the dannywillems/expose-lookup-commitments branch August 21, 2023 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rbonichon rbonichon rbonichon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannywillems @rbonichon