Saffron: storage prototype #3224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anne-laure-s
force-pushed
the
al/storage
branch
2 times, most recently
from
94e48b9 to
762bf93
Compare
anne-laure-s
force-pushed
the
al/encodings
branch
from
ed5b2f8 to
34fb254
Compare
volhovm
previously approved these changes
May 12, 2025
There was a problem hiding this comment.
I'm not sure this is better than implementing some kind of in-memory storage that just writes into the file every now and then automatically, but we can start off with this and change along the way. The final solution will be much smarter I think (some kind of on-disk DB with smart caching is necessary I think).
anne-laure-s
force-pushed
the
al/encodings
branch
from
715be32 to
ce57713
Compare
|
Why do we have these methods in Rust if the state replicator is in OCaml? |
|
Note that you can use different backends already implemented in the Mina codebase. |
anne-laure-s
force-pushed
the
al/encodings
branch
from
ce57713 to
5a880aa
Compare
… utils.rs to a new file
anne-laure-s
force-pushed
the
al/encodings
branch
2 times, most recently
from
fac0dd4 to
aae0111
Compare
anne-laure-s
force-pushed
the
al/encodings
branch
from
0e5867b to
3a1d697
Compare
This function will be used for the storage handling
anne-laure-s
force-pushed
the
al/encodings
branch
from
ccdbd82 to
bd65346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic storage handling for state replicators