Skip to content

Evaluate FB asciiOptimization: true with latest Dart/Flutter #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vaind opened this issue Dec 29, 2021 · 2 comments
Closed

Evaluate FB asciiOptimization: true with latest Dart/Flutter #360

vaind opened this issue Dec 29, 2021 · 2 comments
Assignees
@greenrobot-team
Labels
enhancement New feature or request performance Performance improvement
Milestone
1.6.0

Comments

@vaind
Copy link
Contributor

vaind commented Dec 29, 2021

See TODOs in code_chunks.dart #349 (comment)_

The Dart SDK issue is resolved now by https://dart-review.googlesource.com/c/sdk/+/221467 - after it's part of the released SDK, check the influence on benchmarks
@vaind vaind added the performance Performance improvement label Dec 29, 2021
@vaind vaind mentioned this issue Dec 29, 2021
Merged
1 task
@greenrobot-team greenrobot-team added the enhancement New feature or request label May 24, 2022
@greenrobot-team greenrobot-team self-assigned this Jul 5, 2022
@Vahid1919
Copy link

Vahid1919 commented Jul 11, 2022 •
edited
Loading

asciiOptimization: true performs much better overall. I noticed that the first time I run it with asciiOptimization: true, the readAll takes about 8 ms and then decreases with each run until it stabilises around 6ms after I run it multiple times.
With asciiOptimization: false it is more random and stays between 7-9ms.

Tested on Flutter 3.0.1 & Dart 2.17.1

image

@greenrobot-team
Copy link
Member

Updated TODOs, closing this then.

@greenrobot-team greenrobot-team added this to the 1.6.0 milestone Jul 18, 2022
greenrobot-team pushed a commit that referenced this issue Jul 26, 2022
Evaluate FB asciiOptimization: Remove TODOs in code_chunks.dart #360
26e0ed6 
Replaced TODOs with updated notes regarding benchmark and Flutter/Dart versions used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greenrobot-team greenrobot-team

Labels
enhancement New feature or request performance Performance improvement
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@vaind @greenrobot-team @Vahid1919